Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ResponseValidator.php #36

Closed
wants to merge 1 commit into from

Conversation

bilalghouri
Copy link
Contributor

Issue #35
I debugged the behaviour, the response from transmission rpc was fine, it was sending result object as "duplicate torrent" and argument object was empty.
the validator for addtorrent was parsing it as invalid because of absence of torrent-duplicate object inside arguments.
I have fixed it and requested a pull.

Issue kleiram#35
I debugged the behaviour, the response from transmission rpc was fine, it was sending result object as "duplicate torrent" and argument object was empty. 
the validator for addtorrent was parsing it as invalid because of absence of torrent-duplicate object inside arguments.
I have fixed it and requested a pull.
@kleiram
Copy link
Owner

kleiram commented Oct 19, 2014

'Aight, thanks! Looks like there are some issues though:

  1. The tests are failing (which shouldn't happen)
  2. The code does not adhere to the style of the project.

If you fix the issues, I'll merge!

@kleiram kleiram closed this Feb 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants